@larryh wrote:
Hi,
I just upgraded from 3.3 to 3.4.2 and for the first time saw 5 warnings and dozens of errors when I fired up the server.
The warnings are of the form: node-modules are missing dependency fsevents. This happens to two of them: chokidar and sane
The errors come in 3 flavors:
- You must use double quotes in templates
- Incorrect indentation
- Unexpected partial usage
Regarding the warnings: Since they happen not-in-my-code should I just ignore them and assume that ultimately they will be fixed?
Regarding the errors: Like I said, there are a LOT of these suckers. It’s not like my templates contain crappy code (but then again, we all say that, right
)
- I just happen to always use single quotes instead of double ones.
- I’m a big believer in visual clarity, so my indentations are (to me) very readable.
- My partials are simple HTML code. (I have a Rails background and have always thought that partials were a great idea.) I’ve heard that they might be deprecated, but didn’t worry too much about it because I wasn’t “pushing the envelope” with them.
So for (1) and (2), do you think it’s worth spending a lot of time on truly minor fixes, or is there some kind of ESLint rule that I can use to have these ignored? And even if there is such an exclusionary rule, is there a compelling reason to take the hit and slog through all of these changes?
And for (3), have partials officially been considered bad? If so, should I just replace them with HTML-only components?
Thanks,
Larry
)Posts: 4
Participants: 2