Quantcast
Viewing all articles
Browse latest Browse all 4827

Is this an accepted (not private) way to get the controller from a Transition?

@Hummingbird wrote:

Today, I came across an issue with an add-on I am using. When digging around I noticed that a refactoring towards newer ember versions has been the cause of this. Previously the HandlerInfo of the transition has been used and the replacement to use the RouteInfo seemed to be the cause of the issue.

The only objective is to get a property from the currently active controllers. After some debugging I came up with this solution:

transition.intent.router.currentRouteInfos.some((routeInfo) => 
   get(routeInfo, 'route.controller.preserveScrollPosition')
);

However, I was wondering if this solution is relying on private api we should not be using. For instance the intent property does not seem to be documented for the transition class - not even within private fields.

This is my PR in case additional information is required.

Posts: 1

Participants: 1

Read full topic


Viewing all articles
Browse latest Browse all 4827

Trending Articles