Help refactoring a no-side-effects warning in a CP

@Abuelo wrote:

I’m currently working on a web form where I provide two fields for a user to manually enter a timestamp. The first field is a HH:MM value and the second field is a DD/MM/YYYY. It’s a bit weird but it’s part of the specification.

To take these inputs and turn them into a timestamp that my model can POST I am currently using a computed property to observe changes in the fields, create the date object and then set it in the model:

init(){
  this._super(...arguments);
  this.set('refHours', null); //value of 'time of referral' hours input
  this.set('refDate', null) //value of 'time of referral' date input
},

tor: computed('refHours', 'refDate', function () {
  this.set('model.time_of_referral', createDateString(this.get('refHours'), this.get('refDate')))   
}),

This causes a lint error telling me that I shouldn’t create side effects in CPs, essentially because it’s a level of abstraction.

However, it is doing exactly what I want to it do. I’m struggling to see how I would refactor this and get the same result, particularly as this is obviously a small part of a much larger form.

I’d be super interested in listening to ideas and opinions on either the use case or the warning.

Posts: 2

Participants: 2

Read full topic